Make scheduler preemptive #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
preempt
branch
3 times, most recently
from
769f9ae to
891dfe7
Compare
RalfJung
commented
Jun 7, 2022
| @@ -1,6 +1,6 @@ | |||
| // ignore-windows: Concurrency on Windows is not supported yet. | |||
| // compile-flags: -Zmiri-ignore-leaks | |||
| // error-pattern: | |||
There was a problem hiding this comment.
@oli-obk btw, this was matching the warning that used to be printed when spawning a thread. There was no actual 'error' in this execution. I don't think ui_test should have accepted this.
|
@bors r+ |
|
📌 Commit 11a8b3a has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually fairly easy. :D I just roll the dice on each terminator to decide whether we want to yield the active thread. I think with this we are also justified to no longer show "experimental" warnings when a thread is spawned. :)
Closes #1388